Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/23189
  
    > The logWarning call as the other handler below is also not overridden:
    
    It is. I even copied & pasted the code. I made the change locally and this 
is what happens:
    
    ```
    $ ./bin/spark-submit --class foo bar.jar 
    Warning: Failed to load foo: foo
    ```
    
    With your change, if you are using a file appender instead of a console 
appender, you'll still not see the error on the terminal. For `spark-submit`, 
since it's a user-run script, it's good to print something to the terminal in 
these cases, regardless of the logging configuration.
    
    If you want to also write the full exception to the logs, that's fine, but 
the change I suggested is more correct here considering the use.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to