Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r238036776
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/PartitionTransforms.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalog.v2;
+
+/**
+ * A standard set of transformations that are passed to data sources
during table creation.
+ *
+ * @see PartitionTransform
+ */
+public class PartitionTransforms {
+ private PartitionTransforms() {
+ }
+
+ /**
+ * Create a transform for a column with the given name.
+ * <p>
+ * This transform is used to pass named transforms that are not known to
Spark.
+ *
+ * @param transform a name of the transform to apply to the column
+ * @param colName a column name
+ * @return an Apply transform for the column
+ */
+ public static PartitionTransform apply(String transform, String colName)
{
+ if ("identity".equals(transform)) {
--- End diff --
Is it possible to defer partition support, or is is fundamentally important
enough to get that correct now because we will be building on it on e.g. the
very next evolution of this API and its uses? I'm thinking about how to
minimize the amount of API we're proposing per change, particularly if choices
aren't particularly obvious.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
