Github user gaborgsomogyi commented on the issue:

    https://github.com/apache/spark/pull/22952
  
    @HeartSaVioR 
    I've taken a deeper look at the overlap thing and found the following.
    
    * Added an additional test which produced odd result:
    ```
    ...
          val sourcePath = "/hello/worl"
          val archivePath = "/hello/world/spark"
    ...
    ```
    This has thrown `IllegalArgumentException` but the `sourcePath` is 
different than `archivePath`. 
    This happens without any glob magic.
    
    * This approach may not work if there are symlinks involved 
(`fs.makeQualified` doesn't make any link resolve).
      * HDFS does not support it yet, though on the way, see 
https://issues.apache.org/jira/browse/HADOOP-10019
      * S3 and ADLS does not support it
    
      All in all this part is fine now.
    
    Checking the glob part...



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to