Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r238406928
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -148,11 +148,20 @@ private[spark] class AppStatusStore(
// cheaper for disk stores (avoids deserialization).
val count = {
Utils.tryWithResource(
- store.view(classOf[TaskDataWrapper])
- .parent(stageKey)
- .index(TaskIndexNames.EXEC_RUN_TIME)
- .first(0L)
- .closeableIterator()
+ if (store.isInstanceOf[LevelDB]) {
--- End diff --
Could you invert the check so you don't need to import `LevelDB`? Just to
avoid importing more implementation details of the kvstore module into this
class...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
