Github user LuciferYang commented on a diff in the pull request:
https://github.com/apache/spark/pull/23214#discussion_r238558889
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -398,8 +399,8 @@ private[execution] final class LongToUnsafeRowMap(val
mm: TaskMemoryManager, cap
private var numKeys = 0L
// Tracking average number of probes per key lookup.
- private var numKeyLookups = 0L
- private var numProbes = 0L
+ private var numKeyLookups = new LongAdder
+ private var numProbes = new LongAdder
--- End diff --
Initially, I thought these two variables in class scope will affect SIMD
optimization of JIT(after java8), we try to add `-XX: -UseSuperWord` to
executor java opts to vertify this view, but no affect with spark-2.1,
although this patch can imporve performance....
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
