Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3409#discussion_r20752652
  
    --- Diff: conf/spark-env.sh.template ---
    @@ -40,6 +40,7 @@
     # - SPARK_WORKER_OPTS, to set config properties only for the worker (e.g. 
"-Dx=y")
     # - SPARK_HISTORY_OPTS, to set config properties only for the history 
server (e.g. "-Dx=y")
     # - SPARK_DAEMON_JAVA_OPTS, to set config properties for all daemons (e.g. 
"-Dx=y")
    +# - SPARK_YARN_JAVA_OPTS, to set config properties for Yarn application 
master (e.g. "-Dx=y")
    --- End diff --
    
    This section is for standalone deploy mode, and the options in this file 
should only be for persistent services.  I think we should omit adding an env 
var entirely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to