Github user stczwd commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22575#discussion_r239113033
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -631,6 +631,33 @@ object SQLConf {
         .intConf
         .createWithDefault(200)
     
    +  val SQLSTREAM_WATERMARK_ENABLE = 
buildConf("spark.sqlstreaming.watermark.enable")
    +    .doc("Whether use watermark in sqlstreaming.")
    +    .booleanConf
    +    .createWithDefault(false)
    +
    +  val SQLSTREAM_OUTPUTMODE = buildConf("spark.sqlstreaming.outputMode")
    +    .doc("The output mode used in sqlstreaming")
    +    .stringConf
    +    .createWithDefault("append")
    +
    +  val SQLSTREAM_TRIGGER = buildConf("spark.sqlstreaming.trigger")
    --- End diff --
    
    I don't think there are any problems with this. SQLStreaming is using 
Command to run streaming query, which is similar to InsertIntoHiveTable. 
herefore, the batch SQL and streaming SQL solution is expected.In addition, 
currently an application can only run one streaming SQL.
    Therefore, the batch SQL and streaming SQL solution is expected


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to