Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21465#discussion_r239243683
--- Diff: python/pyspark/ml/classification.py ---
@@ -1174,9 +1165,31 @@ def trees(self):
return [DecisionTreeClassificationModel(m) for m in
list(self._call_java("trees"))]
+class GBTClassifierParams(GBTParams, HasVarianceImpurity):
+ """
+ Private class to track supported GBTClassifier params.
+
+ .. versionadded:: 3.0.0
+ """
+
+ supportedLossTypes = ["logistic"]
+
+ lossType = Param(Params._dummy(), "lossType",
+ "Loss function which GBT tries to minimize
(case-insensitive). " +
+ "Supported options: " + ", ".join(supportedLossTypes),
+ typeConverter=TypeConverters.toString)
+
+ @since("3.0.0")
+ def setLossType(self, value):
--- End diff --
please address the above comment
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
