Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23225#discussion_r239697860
  
    --- Diff: 
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java 
---
    @@ -562,4 +562,18 @@ public void testPeakMemoryUsed() throws Exception {
         }
       }
     
    +  @Test
    +  public void writeEmptyIteratorNotCreateEmptySpillFile() throws Exception 
{
    --- End diff --
    
    This looks like mostly a duplication of `writeEmptyIterator`. Logically, do 
we need to keep both `writeEmptyIterator` and 
`writeEmptyIteratorNotCreateEmptySpillFile` seperately?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to