Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23261#discussion_r239998855 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala --- @@ -210,7 +214,7 @@ abstract class PredictionModel[FeaturesType, M <: PredictionModel[FeaturesType, } } - protected def transformImpl(dataset: Dataset[_]): DataFrame = { + override protected def transformImpl(dataset: Dataset[_]): DataFrame = { --- End diff -- For clarification, some of abstraction already has `transformImpl`.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org