vanzin commented on a change in pull request #19616: [SPARK-22404][YARN]
Provide an option to use unmanaged AM in yarn-client mode
URL: https://github.com/apache/spark/pull/19616#discussion_r240419819
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala
##########
@@ -183,8 +183,13 @@ object YarnSparkHadoopUtil {
)
}
- def getContainerId: ContainerId = {
- val containerIdString =
System.getenv(ApplicationConstants.Environment.CONTAINER_ID.name())
+ def getContainerId(sparkConf: SparkConf): ContainerId = {
+ val containerIdString =
+ if (System.getenv(ApplicationConstants.Environment.CONTAINER_ID.name())
!= null) {
Review comment:
better to use `sparkConf.getenv`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
