cloud-fan commented on a change in pull request #23275: [SPARK-26323][SQL]
Scala UDF should still check input types even if some inputs are of type Any
URL: https://github.com/apache/spark/pull/23275#discussion_r240449840
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
##########
@@ -47,25 +47,13 @@ case class ScalaUDF(
function: AnyRef,
dataType: DataType,
children: Seq[Expression],
- inputsNullSafe: Seq[Boolean],
- inputTypes: Seq[DataType] = Nil,
+ @transient inputsNullSafe: Seq[Boolean],
Review comment:
expressions are usually serialized to executor side. Previously it's fine,
as all data types are case class, which is serializable. But `AnyDataType` is
normal scala object, which is not serializable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
