gaborgsomogyi commented on a change in pull request #23274: [SPARK-26322][SS]
Add spark.kafka.token.sasl.mechanism to ease delegation token configuration.
URL: https://github.com/apache/spark/pull/23274#discussion_r240522377
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Kafka.scala
##########
@@ -79,4 +79,13 @@ private[spark] object Kafka {
"For further details please see kafka documentation. Only used to
obtain delegation token.")
.stringConf
.createOptional
+
+ val TOKEN_SASL_MECHANISM =
+ ConfigBuilder("spark.kafka.token.sasl.mechanism")
Review comment:
The `token` keyword is there for a reason (maybe it can be changed to
reflect the meaning better).
All in all there are 2 `sasl.mechanism` used:
* To obtain token, which is hardcoded to `GSSAPI` at the moment without user
parameter
* To authenticate the obtained token, which is this
To be consistent with the actual naming the first one would be
`spark.kafka.sasl.mechanism` and the second something else.
All in all if we think the naming structure can be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
