Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3238#discussion_r20814231
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -684,6 +737,13 @@ private[spark] object ClientBase extends Logging {
addUserClasspath(args, sparkConf, env)
}
+ // Add datanucleus jars to classpath
+ for (entries <- sparkConf.getOption(CONF_SPARK_DATANUCLEUS_JARS)) {
--- End diff --
Ah, I see what you're doing. You're manually adding all the datanucleus
jars to the classpath by propagating the config. I wonder if, for the sake of
simplicity, piggybacking on `cachedSecondaryJarLinks` is good enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
