dongjoon-hyun commented on a change in pull request #23266: [SPARK-26313][SQL]
move read related methods from Table to read related mix-in traits
URL: https://github.com/apache/spark/pull/23266#discussion_r241054082
##########
File path: sql/core/src/main/java/org/apache/spark/sql/sources/v2/Table.java
##########
@@ -37,23 +35,14 @@
public interface Table {
/**
- * A name to identify this table. Implementations should provide a
meaningful name, like the
- * database and table name from catalog, or the location of files for this
table.
- */
- String name();
-
- /**
- * Returns the schema of this table.
+ * Returns the schema of this table. If the table is not readable and
doesn't have a schema, an
+ * empty schema can be returned here.
*/
StructType schema();
/**
- * Returns a {@link ScanBuilder} which can be used to build a {@link Scan}
later. Spark will call
- * this method for each data scanning query.
- * <p>
- * The builder can take some query specific information to do operators
pushdown, and keep these
- * information in the created {@link Scan}.
- * </p>
+ * A name to identify this table. Implementations should provide a
meaningful name, like the
+ * database and table name from catalog, or the location of files for this
table.
*/
- ScanBuilder newScanBuilder(DataSourceOptions options);
+ String name();
Review comment:
Can we move `name()` before `schema()` like before? That will reduce the
number of changed lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
