HyukjinKwon commented on a change in pull request #23266: [SPARK-26313][SQL]
move `newScanBuilder` from Table to read related mix-in traits
URL: https://github.com/apache/spark/pull/23266#discussion_r241289429
##########
File path: sql/core/src/main/java/org/apache/spark/sql/sources/v2/Table.java
##########
@@ -43,17 +41,8 @@
String name();
/**
- * Returns the schema of this table.
+ * Returns the schema of this table. If the table is not readable and
doesn't have a schema, an
+ * empty schema can be returned here.
*/
StructType schema();
Review comment:
It's also weird that write side needs a schema in a way because we need it
only when Append mode (correct me if I missed some discussions or changes).
Sounds like we're adding `schema` for one exception case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
