Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3439#discussion_r20885397
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/SquaredError.scala ---
@@ -49,18 +48,17 @@ object SquaredError extends Loss {
}
/**
- * Method to calculate error of the base learner for the gradient
boosting calculation.
+ * Method to calculate loss of the base learner for the gradient
boosting calculation.
* Note: This method is not used by the gradient boosting algorithm but
is useful for debugging
* purposes.
- * @param model Model of the weak learner.
+ * @param model Ensemble model
* @param data Training dataset: RDD of
[[org.apache.spark.mllib.regression.LabeledPoint]].
- * @return
+ * @return Mean squared error of model on data
--- End diff --
I'll remove the 1/2. It's probably better to have an odd loss (which only
experts need to know about) than to have an odd name (which everyone needs to
recognize).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
