gengliangwang commented on a change in pull request #23310:
[SPARK-26363][WebUI] Avoid duplicated KV store lookups for task table
URL: https://github.com/apache/spark/pull/23310#discussion_r243322702
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -348,9 +348,9 @@ $(document).ready(function () {
// prepare data for executor summary table
stageExecutorSummaryInfoKeys =
Object.keys(responseBody.executorSummary);
+ var executorDetailsMap = {};
$.getJSON(createRESTEndPointForExecutorsPage(appId),
function(executorSummaryResponse, status, jqXHR) {
- var executorDetailsMap = {};
executorSummaryResponse.forEach(function (executorDetail) {
executorDetailsMap[executorDetail.id] = executorDetail;
Review comment:
Oh sorry about that. I thought the ajax calls was i serial(which makes no
sense at all)..
Then I think we should just use a hash map in the backend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
