cloud-fan commented on a change in pull request #22284: [SPARK-25278][SQL]
Avoid duplicated Exec nodes when the same logical plan appears in the query
URL: https://github.com/apache/spark/pull/22284#discussion_r243871620
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/QueryPlanner.scala
##########
@@ -81,7 +81,7 @@ abstract class QueryPlanner[PhysicalPlan <:
TreeNode[PhysicalPlan]] {
childPlans.map { childPlan =>
// Replace the placeholder by the child plan
candidateWithPlaceholders.transformUp {
- case p if p == placeholder => childPlan
+ case p if p.eq(placeholder) => childPlan
Review comment:
We can reproduce the bug with any plan which has more than one child but
doesn't dedup the expr id. `Union` is one of them. I'm not sure if `Union` is
the only one though...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
