cloud-fan commented on a change in pull request #23376: [SPARK-26435][SQL] Support creating partitioned table using Hive CTAS by specifying partition column names URL: https://github.com/apache/spark/pull/23376#discussion_r243950812
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ########## @@ -1213,16 +1216,25 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder(conf) { ctx) Review comment: then can we check `dataCols` directly? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org