Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3443#discussion_r20976923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -106,12 +106,17 @@ case class Multiply(left: Expression, right:
Expression) extends BinaryArithmeti
case class Divide(left: Expression, right: Expression) extends
BinaryArithmetic {
def symbol = "/"
- override def nullable = left.nullable || right.nullable ||
dataType.isInstanceOf[DecimalType]
+ override def nullable = true
- override def eval(input: Row): Any = dataType match {
- case _: FractionalType => f2(input, left, right, _.div(_, _))
- case _: IntegralType => i2(input, left , right, _.quot(_, _))
- }
+ override def eval(input: Row): Any =
+ if(right.eval(input) == 0) {
--- End diff --
I'm wondering we should check equality between the evaluated right value
and zero here because evaluating `right.eval(input)` happens twice, here and in
`f2` or `i2`.
Should be at around `_.div(_, _)` or `_.quot(_, _)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
