gengliangwang commented on a change in pull request #23387: [SPARK-26447][SQL]Allow OrcColumnarBatchReader to return less partition columns URL: https://github.com/apache/spark/pull/23387#discussion_r244454606
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala ########## @@ -539,6 +539,25 @@ object PartitioningUtils { }).asNullable } + def requestedPartitionColumnIds( Review comment: The returned value depends on the parameter `requiredSchema`. The parameter can be full schema or requested schema. Do you have suggestion for the method name? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org