gatorsmile commented on a change in pull request #22395: [SPARK-16323][SQL] Add
IntegralDivide expression
URL: https://github.com/apache/spark/pull/22395#discussion_r244457203
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -314,6 +314,34 @@ case class Divide(left: Expression, right: Expression)
extends DivModLike {
override def evalOperation(left: Any, right: Any): Any = div(left, right)
}
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+ usage = "expr1 _FUNC_ expr2 - Divide `expr1` by `expr2` rounded to the long
integer. It returns NULL if an operand is NULL or `expr2` is 0.",
+ examples = """
+ Examples:
+ > SELECT 3 _FUNC_ 2;
+ 1
+ """,
+ since = "2.5.0")
+// scalastyle:on line.size.limit
+case class IntegralDivide(left: Expression, right: Expression) extends
DivModLike {
+
+ override def inputType: AbstractDataType = IntegralType
+ override def dataType: DataType = LongType
+
+ override def symbol: String = "/"
Review comment:
What is the reason we are using `/` here? Any benefit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
