Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/3484#discussion_r21039046 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -106,10 +106,14 @@ private[spark] class ApplicationMaster(args: ApplicationMasterArguments, val isLastAttempt = client.getAttemptId().getAttemptId() >= maxAppAttempts if (!finished) { - // this shouldn't ever happen, but if it does assume weird failure - finish(FinalApplicationStatus.FAILED, + // This happens when the user application calls System.exit(). We have the choice + // of either failing of succeeding at this point. We report success to avoid --- End diff -- nit - of should be or
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org