gatorsmile commented on a change in pull request #22936: [SPARK-19799] Support
WITH clause (CTE) in subqueries
URL: https://github.com/apache/spark/pull/22936#discussion_r244628855
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -535,7 +535,19 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
|q2 as (select * from testData where key = '4')
|select * from q1 union all select * from q2""".stripMargin),
Row(5, "5") :: Row(4, "4") :: Nil)
+ }
+ test("SPARK-19799: Support WITH clause in subqueries") {
Review comment:
Could you add more test cases? For example, can a with clause in a subquery
shadow a with clause in an enclosing query with the same name? Another example,
use with clauses in a subquery expression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
