maropu commented on a change in pull request #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INTERVAL clauses URL: https://github.com/apache/spark/pull/20433#discussion_r244630000
########## File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql ########## @@ -0,0 +1,185 @@ +-- Basic tests for intervals +--SET spark.sql.parser.ansi.enabled=true + +select + '1' second, + 2 seconds, Review comment: Regardless of whether seconds reserved or not, this pr currently regards the statement as interval. Anyway, IMO seconds and the other units should be reserved in the ANSI mode. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
