srowen commented on a change in pull request #23391: [SPARK-26456][SQL] Cast date/timestamp to string by Date/TimestampFormatter URL: https://github.com/apache/spark/pull/23391#discussion_r244656099
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala ########## @@ -230,7 +235,7 @@ object PartitioningUtils { // Once we get the string, we try to parse it and find the partition column and value. val maybeColumn = parsePartitionColumn(currentPath.getName, typeInference, userSpecifiedDataTypes, - validatePartitionColumns, timeZone) + validatePartitionColumns, timeZone, dateFormatter, timestampFormatter) Review comment: @MaxGekk you probably have a better summary than I do, but is the problem fundamentally about writing formatted dates incorrectly? older dates would have slightly the wrong hour/minute, and was it because the timezone wasn't fully and correctly specified? and this would manifest if writing to JSON or CSV? yeah, a brief summary of the type of bug that was fixed by the new parser would be helpful in the release notes (just "Docs text" of the JIRA) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org