LantaoJin commented on a change in pull request #22874: [SPARK-25865][CORE] Add GC information to ExecutorMetrics URL: https://github.com/apache/spark/pull/22874#discussion_r244697492
########## File path: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ########## @@ -99,6 +100,61 @@ case object ProcessTreeMetrics extends ExecutorMetricType { } } +case object GarbageCollectionMetrics extends ExecutorMetricType { + import GC_TYPE._ + override val names = Seq( + "MinorGCCount", + "MinorGCTime", + "MajorGCCount", + "MajorGCTime" + ) + override private[spark] def getMetricValues(memoryManager: MemoryManager): Array[Long] = { + var allMetrics = GCMetrics(0, 0, 0, 0) Review comment: Agree ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org