dongjoon-hyun commented on a change in pull request #23415: [SPARK-26445][CORE]
Use ConfigEntry for hardcoded configs for driver/executor categories.
URL: https://github.com/apache/spark/pull/23415#discussion_r244919000
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -130,7 +138,11 @@ package object config {
private[spark] val EXECUTOR_USER_CLASS_PATH_FIRST =
ConfigBuilder("spark.executor.userClassPathFirst").booleanConf.createWithDefault(false)
- private[spark] val EXECUTOR_MEMORY = ConfigBuilder("spark.executor.memory")
+ private[spark] val EXECUTOR_CORES =
ConfigBuilder(SparkLauncher.EXECUTOR_CORES)
Review comment:
Could you describe a little bit more about this pattern in the PR
description? This PR seems to be different from the PR description (and other
related PRs) because the strings exists in `SparkLauncher` instead of this
`org.apache.spark.internal.config` (although we use this configurations in
other places).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
