Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3380#issuecomment-65090864
Actually, I realized it might simplify this patch a lot if instead of
extending BlockManager, we extend SortShuffleManager which returns a
ShuffleBlockManager that injects a wait into getBlockData.
This way you could just do
```scala
val myConf = conf.duplicate
.set("spark.shuffle.manager", clasOf[SlowShuffleBlockManager].getName)
sc = new SparkContext(myConf)
```
rather than doing all this work creating SparkEnvs and such, which will be
annoying any time we add a new parameter to BlockManager or SparkEnv.
Note that I would also refactor this whole suite to construct a single conf
once:
`val conf = new
SparkConf().setMaster("local").setAppName("SparkListenerSuite")`
and in each test to just use
`sc = new SparkContext(conf)`
(rather than in `before`)
This would allow constructing special SparkContexts without having to have
2 simultaneously like you do with sc2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
