Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3517#issuecomment-65101627 > Would it not be better to start a new branch (pv-docs-note-on-jsonFile-format/02) that I rebase of current master and only has the actual change (and not the initial change that was too verbose) ? That isn't necessary; when we merge pull requests, we use a script which squashes all commits in the PR down to a single combined commit, so it's fine to have many intermediate commits on this pull request's branch. I'd actually prefer if it if you pushed your new commit to this branch so that the discussion can stay on the same PR / page.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org