gatorsmile commented on a change in pull request #22903: [SPARK-24196][SQL] 
Implement Spark's own GetSchemasOperation
URL: https://github.com/apache/spark/pull/22903#discussion_r245864597
 
 

 ##########
 File path: 
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
 ##########
 @@ -41,7 +41,7 @@
   .addStringColumn("TABLE_SCHEM", "Schema name.")
   .addStringColumn("TABLE_CATALOG", "Catalog name.");
 
-  private RowSet rowSet;
+  protected RowSet rowSet;
 
 Review comment:
   
https://github.com/apache/spark/commit/7feeb82cb7f462e44f7e698c7c3b6ac3a77aade4 
shows we want to further cleanup and improve the thrift-server. Even if 
https://issues.apache.org/jira/browse/HIVE-16391 is resolved, we will still 
keep the Hive thrift-server. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to