dongjoon-hyun commented on a change in pull request #22617:
[SPARK-25484][SQL][TEST] Refactor ExternalAppendOnlyUnsafeRowArrayBenchmark
URL: https://github.com/apache/spark/pull/22617#discussion_r246303032
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArrayBenchmark.scala
##########
@@ -32,9 +32,10 @@ import
org.apache.spark.util.collection.unsafe.sort.UnsafeExternalSorter
* {{{
* 1. without sbt:
* bin/spark-submit --class <this class> --jars <spark core test jar>
<spark sql test jar>
- * 2. build/sbt "sql/test:runMain <this class>"
+ * 2. build/sbt build/sbt ";project sql;set javaOptions
+ * * in Test += \"-Dspark.memory.debugFill=false\";test:runMain <this
class>"
* 3. generate result: SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt ";project
sql;set javaOptions
- * in Test -= \"-Dspark.memory.debugFill=true\";test:runMain <this
class>"
+ * in Test += \"-Dspark.memory.debugFill=false\";test:runMain <this
class>"
Review comment:
Ur, in PR description, `runMain` is repeated twice; `test:runMain
test:runMain`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
