viirya commented on a change in pull request #22807: [SPARK-25811][PySpark]
Raise a proper error when unsafe cast is detected by PyArrow
URL: https://github.com/apache/spark/pull/22807#discussion_r246664769
##########
File path: python/pyspark/sql/tests.py
##########
@@ -4961,6 +4961,31 @@ def foofoo(x, y):
).collect
)
+ def test_pandas_udf_detect_unsafe_type_conversion(self):
+ from distutils.version import LooseVersion
+ from pyspark.sql.functions import pandas_udf
+ import pandas as pd
+ import numpy as np
+ import pyarrow as pa
+
+ values = [1.0] * 3
+ pdf = pd.DataFrame({'A': values})
+ df = self.spark.createDataFrame(pdf).repartition(1)
+
+ @pandas_udf(returnType="int")
+ def udf(column):
+ return pd.Series(np.linspace(0, 1, 3))
+
+ udf_boolean = df.select(['A']).withColumn('udf', udf('A'))
+
+ # Since 0.11.0, PyArrow supports the feature to raise an error for
unsafe cast.
+ if LooseVersion(pa.__version__) >= LooseVersion("0.11.0"):
Review comment:
If using `safe=False` by default, it is possible to break user's code
without notifications. If using `safe=True` by default, it still breaks user's
code, but there is error message so it should let user know what's happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
