Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21218170
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -53,7 +53,9 @@ class BlockManagerMasterActor(val isLocal: Boolean, conf:
SparkConf, listenerBus
private val akkaTimeout = AkkaUtils.askTimeout(conf)
val slaveTimeout =
conf.getLong("spark.storage.blockManagerSlaveTimeoutMs",
- math.max(conf.getInt("spark.executor.heartbeatInterval", 10000) * 3,
45000))
--- End diff --
How about
```scala
```scala
val slaveTimeout = {
val defaultMs = math.max(conf.getInt("spark.executor.heartbeatInterval",
10000) * 3, 45000)
val networkTimeout = conf.getInt("spark.network.timeout", defaultMs /
1000)
conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", networkTimeout)
}
```
I'm still not sure why we cap it to 45000 by default ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
