purijatin commented on issue #23549: [SPARK-26616][MLlib] Expose document 
frequency in IDFModel
URL: https://github.com/apache/spark/pull/23549#issuecomment-455162286
 
 
   Sure. Thanks for the long message. Will revert the changes shortly.
   And I did learn a few things :).
   
   PS: One tiny advantage of spark-version based instead of model version is 
that, it is easier to track during spark upgrades. If things break, it is 
easier to scan as spark version is apparent. With the model change, it is not 
very apparent on the face of it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to