vanzin commented on a change in pull request #19616: [SPARK-22404][YARN] Provide an option to use unmanaged AM in yarn-client mode URL: https://github.com/apache/spark/pull/19616#discussion_r248862990
########## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ########## @@ -70,6 +73,11 @@ private[spark] class Client( private val isClusterMode = sparkConf.get("spark.submit.deployMode", "client") == "cluster" + private val isClientUnmanagedAMEnabled = sparkConf.get(YARN_UNMANAGED_AM) && !isClusterMode + private var amServiceStarted = false + private var appMaster: ApplicationMaster = _ + private var unManagedAMStagingDirPath: Path = _ Review comment: Seems better to just store this in a variable for all cases. It's recomputed from the conf in a few different places in this class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org