inpefess commented on a change in pull request #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1 URL: https://github.com/apache/spark/pull/20691#discussion_r249090813
########## File path: python/pyspark/cloudpickle.py ########## @@ -42,20 +42,26 @@ """ from __future__ import print_function -import dis -from functools import partial -import imp import io -import itertools -import logging +import dis Review comment: > Not a big deal but did these imports need to shuffle? I'm not clear what was added or removed It's an exact copy of cloudpickle 0.6.1 code. So the import order was not shuffled by me on purpose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
