HyukjinKwon commented on a change in pull request #23519: [SPARK-26601][SQL] 
Make broadcast-exchange thread pool configurable
URL: https://github.com/apache/spark/pull/23519#discussion_r249317928
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
 ##########
 @@ -126,4 +126,13 @@ object StaticSQLConf {
       .intConf
       .createWithDefault(1000)
 
+  val MAX_BROADCAST_EXCHANGE_THREADNUMBER =
+    buildStaticConf("spark.sql.broadcastExchange.maxThreadNumber")
+      .doc("The maximum degree of parallelism to fetch and broadcast the 
table.If we " +
+        "encounter memory issue when broadcast table we can decrease this 
number." +
+        "Notice the number should be carefully chosen since decrease 
parallelism will " +
+        "cause longer waiting for other broadcasting.And increase parallelism 
may " +
 
 Review comment:
   `broadcasting.And` -> `broadcasting. Also, incresing`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to