Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3587#discussion_r21372796
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
@@ -32,7 +33,65 @@ private[spark] object JavaUtils {
def mapAsSerializableJavaMap[A, B](underlying: collection.Map[A, B]) =
new SerializableMapWrapper(underlying)
+ // Implementation is copied from
scala.collection.convert.Wrappers.MapWrapper,
--- End diff --
Good question. It appears to be licensed just like the rest of the Scala
code (http://www.scala-lang.org/license.html) Spark already integrates some
Scala code and has the proper entries in `LICENSE` as a result. I can modify
the text to clearly call out that part of `MapWrapper` was copied, for good
measure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
