Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/3409#issuecomment-65812731
I'm personally not a fan of executorLauncher. Cluster mode also launches
executors and users shouldn't really have to know executorLauncher = client
mode. If you want to change the name then we should be explicit this is for
yarn client mode only then (spark.yarn.clientmode.am.extraJavaOptions or
similar). Otherwise I don't see how you get around some sort of confusion.
You can make it apply to both but then you have to define presendence between
it and driver.extraJavOptions and if users have both set and don't realize the
presendence they get unexpected behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
