Github user ankurdave commented on a diff in the pull request: https://github.com/apache/spark/pull/3619#discussion_r21393556 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala --- @@ -139,6 +146,14 @@ object Pregel extends Logging { // get to send messages. We must cache messages so it can be materialized on the next line, // allowing us to uncache the previous iteration. messages = g.mapReduceTriplets(sendMsg, mergeMsg, Some((newVerts, activeDirection))).cache() + + if (checkpoint && i % checkpointFrequency == checkpointFrequency - 1) { + logInfo("Checkpointing in iteration " + i) + g.vertices.checkpoint() --- End diff -- We merged a simpler fix for graph checkpointing in https://issues.apache.org/jira/browse/SPARK-4672. I think this fixes SPARK-3623 -- are the extra changes to Spark core in your PR necessary?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org