dongjoon-hyun commented on a change in pull request #23639: [SPARK-26716][SQL]
FileFormat: the supported types of read/write should be consistent
URL: https://github.com/apache/spark/pull/23639#discussion_r250869623
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
##########
@@ -156,7 +156,7 @@ trait FileFormat {
* Returns whether this format supports the given [[DataType]] in read/write
path.
* By default all data types are supported.
*/
- def supportDataType(dataType: DataType, isReadPath: Boolean): Boolean = true
+ def supportsDataType(dataType: DataType): Boolean = true
Review comment:
Sorry, but we also have `supportBatch` in this file. If this is just a
cosmetic issue, I prefer to keep the existing consistency in this single class.
Also, we still use `supportCodegen` in other classes, too.
> 2. rename to supportsDataType, which is more consistent with other data
source API(e.g. SupportsBatchRead, SupportsBatchWrite).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
