arunmahadevan commented on issue #23634: [SPARK-26154][SS] Streaming left/right 
outer join should not return outer nulls for already matched rows
URL: https://github.com/apache/spark/pull/23634#issuecomment-457796192
 
 
   What I meant was in `update` mode the partial results can be emitted first 
and later result can overwrite the earlier ones. Whereas in `append` mode the 
final matched row should be emitted once. Emitting a matched row first and a 
null-matched row later like observed here is clearly wrong. 
   
   The rows in one of the inputs are immediately discarded while I think both 
inputs should be retained till the watermark of the operator advances so that 
the correct results can be produced.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to