viirya commented on a change in pull request #23650: [SPARK-26728]Make
rdd.unpersist blocking configurable
URL: https://github.com/apache/spark/pull/23650#discussion_r251191724
##########
File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
##########
@@ -209,13 +210,14 @@ abstract class RDD[T: ClassTag](
*/
def cache(): this.type = persist()
+ private val unpersistBlocking = conf.get(RDD_UNPERSIST_BLOCKING)
/**
* Mark the RDD as non-persistent, and remove all blocks for it from memory
and disk.
*
* @param blocking Whether to block until all blocks are deleted.
* @return This RDD.
*/
- def unpersist(blocking: Boolean = true): this.type = {
+ def unpersist(blocking: Boolean = unpersistBlocking): this.type = {
Review comment:
As @srowen said, I'd say that it is controlled by the caller. You can decide
to call it with blocking=false without using default value.
I'm not sure if making false as default will affect existing programs. After
a call to unpersist without blocking parameter, the blocks may still exist,
will it cause unexpected effect? Like OOM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
