gatorsmile commented on a change in pull request #23658: [SPARK-26735][SQL]
Verify plan integrity for special expressions
URL: https://github.com/apache/spark/pull/23658#discussion_r251206277
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerStructuralIntegrityCheckerSuite.scala
##########
@@ -35,6 +36,8 @@ class OptimizerStructuralIntegrityCheckerSuite extends
PlanTest {
case Project(projectList, child) =>
val newAttr = UnresolvedAttribute("unresolvedAttr")
Project(projectList ++ Seq(newAttr), child)
+ case agg @ Aggregate(Nil, aggregateExpressions, child) =>
+ Project(aggregateExpressions, child)
Review comment:
Add a comment here to explain Project is unable to handle Aggregate
expressions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
