gengliangwang commented on a change in pull request #23601:
[WIP][SPARK-26673][SQL] File source V2 writes: create framework and migrate ORC
URL: https://github.com/apache/spark/pull/23601#discussion_r251242224
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScan.scala
##########
@@ -18,22 +18,29 @@ package org.apache.spark.sql.execution.datasources.v2
import org.apache.hadoop.fs.Path
-import org.apache.spark.sql.SparkSession
+import org.apache.spark.sql.{AnalysisException, SparkSession}
import org.apache.spark.sql.execution.PartitionedFileUtil
import org.apache.spark.sql.execution.datasources._
import org.apache.spark.sql.sources.v2.reader.{Batch, InputPartition, Scan}
-import org.apache.spark.sql.types.StructType
+import org.apache.spark.sql.types.{DataType, StructType}
abstract class FileScan(
sparkSession: SparkSession,
- fileIndex: PartitioningAwareFileIndex) extends Scan with Batch {
+ fileIndex: PartitioningAwareFileIndex,
+ schema: StructType) extends Scan with Batch {
/**
* Returns whether a file with `path` could be split or not.
*/
def isSplitable(path: Path): Boolean = {
false
}
+ /**
+ * Returns whether this format supports the given [[DataType]] in write path.
+ * By default all data types are supported.
+ */
+ def supportDataType(dataType: DataType): Boolean = true
Review comment:
I think we can implement the supportDataType API in another PR. This PR is
ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
