HeartSaVioR commented on a change in pull request #23652:
[SPARK-26718][SS][BRANCH-2.4] Fixed integer overflow
URL: https://github.com/apache/spark/pull/23652#discussion_r251266914
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala
##########
@@ -199,6 +199,41 @@ abstract class KafkaMicroBatchSourceSuiteBase extends
KafkaSourceSuiteBase {
StopStream)
}
+
+ test("Rate limit set to Long.Max should not overflow integer during end
offset calculation[SPARK-26718]") {
Review comment:
nit: There's actually no rule on this, but most of the cases JIRA title is
used as a prefix (search "SPARK-" against `*Suite.scala`) so might be better to
follow the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
