dongjoon-hyun commented on a change in pull request #23666:
[SPARK-26718][SS][Master] Fixed integer overflow in SS kafka rateLimit
calculation
URL: https://github.com/apache/spark/pull/23666#discussion_r251278932
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala
##########
@@ -204,6 +204,40 @@ abstract class KafkaMicroBatchSourceSuiteBase extends
KafkaSourceSuiteBase {
StopStream)
}
+ test("Rate limit set to Long.Max should not overflow integer during end
offset calculation[SPARK-26718]") {
+ val topic = newTopic()
+ testUtils.createTopic(topic, partitions = 1)
+ testUtils.sendMessages(topic, (0 until 5000).map(_.toString).toArray,
Some(0)) // fill in 5000 messages to trigger potential integer overflow
+
Review comment:
Shall we remove empty line 211 since we have two empty line (211~212)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
