viirya commented on a change in pull request #23668: [SPARK-26660][FOLLOWUP]
Add warning logs when broadcasting large task binary
URL: https://github.com/apache/spark/pull/23668#discussion_r251297474
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1162,7 +1162,7 @@ private[spark] class DAGScheduler(
partitions = stage.rdd.partitions
}
- if (taskBinaryBytes.length * 1000 > TaskSetManager.TASK_SIZE_TO_WARN_KB)
{
+ if (taskBinaryBytes.length > TaskSetManager.TASK_SIZE_TO_WARN_KB * 1000)
{
Review comment:
We use 1024 at L497 in TaskSetManager:
```scala
if (serializedTask.limit() > TaskSetManager.TASK_SIZE_TO_WARN_KB * 1024 &&
!emittedTaskSizeWarning) {
emittedTaskSizeWarning = true
logWarning(s"Stage ${task.stageId} contains a task of very large size " +
s"(${serializedTask.limit() / 1024} KB). The maximum recommended task
size is " +
s"${TaskSetManager.TASK_SIZE_TO_WARN_KB} KB.")
}
```
Shall we use a consistent value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
